Showing results for 
Search instead for 
Did you mean: 
Helper II
Helper II

Modelling and DAX advice

Hi experts.


I know that the goal is to have simple DAX and the best way to achieve that is by designing the model carefully.

I am still in the early stages of my DAX journey; However, my place of work like to make things complicated!


The purpose of the report is to find product prices where the margin is equal or below a threshold (set vie a What-If parameter).


Here is a mock-up of the model I have created: pbix download from OneDrive 


I have chosen to use two fact tables – even though 95% of the fields are the same. This is because General Promos, unlike the other types of prices are open to all customers (no relationship to customer).


What I would like is some advice (or reassurance) that the model is the best design to achieve my brief. Also, my DAX appears to function, but I wonder if I could/should redesign to improve performance. Any advice/examples, especially in the DAX department would be much appreciated.


Thanks in  advance



Community Support
Community Support

Hi  @music43 ,

Do you try to put all the fields you need in the data source into a table, use the fields of the whole table, so that you don't need more measures to work

Data Modelling In Power BI: Helpful Tips & Best Pr... - Microsoft Power BI Community

Understand star schema and the importance for Power BI - Power BI | Microsoft Docs

Best Regards,

Liu Yang

If this post helps, then please consider Accept it as the solution to help the other members find it more quickly.

Helper II
Helper II


Helpful resources

Power Platform Conf 2022 768x460.jpg

Join us for Microsoft Power Platform Conference

The first Microsoft-sponsored Power Platform Conference is coming in September. 100+ speakers, 150+ sessions, and what's new and next for Power Platform.

Power BI Dev Camp Session 23 768x460.jpg

Check it Out!

Mark your calendars and join us on Thursday, June 30 at 11a PDT for a great session with Ted Pattison!

Top Solution Authors
Top Kudoed Authors